Wireshark-commits: [Wireshark-commits] master c079255: Add an API to let a postdissector specify fi
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 12 Apr 2017 04:31:46 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c0792555392f234ab96917e784d365b5de053836
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

c079255 by Guy Harris (guy@xxxxxxxxxxxx):

    Add an API to let a postdissector specify fields whose values it needs.
    
    Currently, this is only used to determine whether a protocol tree needs
    to be built on the first pass or not - if there are postdissectors that
    need fields, it does - but eventually we should be able to use it to
    prime the dissection to deliver those fields in cases where we don't
    need the *entire* protocol tree (rather than using a hack such as
    cooking up a fake tap with a fake filter to do that).
    
    Update MATE and TRANSUM to use it.
    
    Clean up code to check whether we need a protocol tree, and add comments
    before that code indicating, in each case, what the criteria are.
    
    The array of postdissectors includes a length, so we don't need to
    separately keep track of the number of postdissectors.
    
    Clean up indentation while we're at it.
    
    Change-Id: I71d4025848206d144bc54cc82941089a50e80ab7
    Reviewed-on: https://code.wireshark.org/review/21029
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  aa9a0b3   cmake: fix sporadic WSDG build failure on Windows
    adds  c079255   Add an API to let a postdissector specify fields whose values it needs.


Summary of changes:
 debian/libwireshark0.symbols     |    2 +
 epan/packet.c                    |   84 ++++++++++++++++++++++++++-------
 epan/packet.h                    |   39 ++++++++++++++-
 epan/wslua/wslua_proto.c         |   10 ++++
 file.c                           |   97 ++++++++++++++++++++++++++++++++------
 plugins/mate/mate.h              |    2 +
 plugins/mate/mate_setup.c        |   12 +++++
 plugins/mate/packet-mate.c       |    9 +++-
 plugins/transum/packet-transum.c |   24 ++++++++--
 sharkd.c                         |   40 +++++++++++-----
 tfshark.c                        |   65 +++++++++++++++++++------
 tshark.c                         |   95 +++++++++++++++++++++++++++++--------
 ui/gtk/packet_list_store.c       |   10 ++++
 ui/qt/packet_list_record.cpp     |   12 +++++
 14 files changed, 418 insertions(+), 83 deletions(-)