Wireshark-commits: [Wireshark-commits] master 043df01: Add support for BASE_VALS_NO_UNKNOWN
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 10 Apr 2017 20:32:17 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=043df01c5645378bd61318c20cfdbf86c8f73288
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

043df01 by Alexis La Goutte (alexis.lagoutte@xxxxxxxxx):

    Add support for BASE_VALS_NO_UNKNOWN
    
    BASE_VALS_NO_UNKNOWN is a special value_string value for only a single
    (maybe 2) numerical value(s).  If a field has the numerical value
    that doesn't match anything in the value_string, just the number
    is supplied for the field (no "Unknown")
    
    Dissectors that had this use case have been converted in the patch.
    
    Change-Id: Ie63a36cceec2fe4436938ec7e3d7f9e690d2b8d9
    Reviewed-on: https://code.wireshark.org/review/20736
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  ded9ad7   IEEE 802.15.4: Add support for Thread, MLE and ZigBee IP
    adds  043df01   Add support for BASE_VALS_NO_UNKNOWN


Summary of changes:
 doc/README.dissector             |   11 ++-
 epan/dissectors/packet-alcap.c   |   25 ++++---
 epan/dissectors/packet-btavrcp.c |   14 ++--
 epan/dissectors/packet-icmpv6.c  |  140 ++++++++++----------------------------
 epan/dissectors/packet-ipmi-se.c |   77 ++++++++-------------
 epan/dissectors/packet-iso7816.c |   30 ++++----
 epan/dissectors/packet-l2tp.c    |   29 +++-----
 epan/dissectors/packet-llrp.c    |  133 +++++++++++++++---------------------
 epan/dissectors/packet-pim.c     |   93 +++++++++----------------
 epan/dissectors/packet-smb2.c    |   15 ++--
 epan/proto.c                     |   32 +++++++--
 epan/proto.h                     |    1 +
 plugins/docsis/packet-docsis.c   |   16 ++---
 plugins/docsis/packet-mdd.c      |   13 ++--
 plugins/wimax/msg_reg_req.c      |   21 +++---
 15 files changed, 271 insertions(+), 379 deletions(-)