Wireshark · Wireshark-commits: [Wireshark-commits] master 92ebd63: netlink: let subdissectors handle the netlink header

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=92ebd6389203448168a2769fa473bbbad95ec159
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

92ebd63 by Peter Wu (peter@xxxxxxxxxxxxx):

    netlink: let subdissectors handle the netlink header
    
    Let subdissectors handle parsing and addition of the Netlink header
    instead of doing this before calling subdissectors. After this patch:
    
     - Protocol filters like "netlink-netfilter" can be used to match
       packets (previously only a text item was added to the tree).
     - Subdissectors have more freedom in modifying the type field, so now
       it shows the correct type directly rather than "Message type:
       Protocol-specific".
     - netfilter: the type fields are now actually linked to a tvb,
       previously it was linked to a NULL tvb.
     - netfilter: fix unintended rejection of packets (the length should
       have been added to the offset, otherwise it would fallback to the
       data dissector).
     - Now subdissectors will not be called for control messages (so the
       netlink-conntrack.pcap sample now shows "Netlink" instead of "Netlink
       route" for the "End of dump" control message).
    
    Change-Id: I2ab1bef91fb0080664195b281a6a45c9702914e5
    Reviewed-on: https://code.wireshark.org/review/20910
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  0add542   netlink: add helper for dissecting an array of attributes
    adds  92ebd63   netlink: let subdissectors handle the netlink header


Summary of changes:
 epan/dissectors/packet-netlink-netfilter.c |   49 +++++++++--------
 epan/dissectors/packet-netlink-route.c     |   44 ++++++---------
 epan/dissectors/packet-netlink-sock_diag.c |   28 ++++------
 epan/dissectors/packet-netlink.c           |   82 ++++++++++++++++++++--------
 epan/dissectors/packet-netlink.h           |    6 ++
 5 files changed, 121 insertions(+), 88 deletions(-)