Wireshark-commits: [Wireshark-commits] master b9b5703: Qt: Remember exact position of selected item
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 7 Apr 2017 08:51:59 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b9b5703a41a52d9494c0179e42bbf5c62c7dcb05
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

b9b5703 by Peter Wu (peter@xxxxxxxxxxxxx):

    Qt: Remember exact position of selected item in tree
    
    When switching between packets, the first field at a level would be
    selected. This is annoying if you have similarly structured trees (like
    TLVs or text labels).
    
    Combined with something like bug 13533, this causes erratic jumping. Fix
    this by incorporating the level position in the path.
    
    Change-Id: I998853ce899fffc69dd4932902508141325c35a4
    Ping-Bug: 13533
    Reviewed-on: https://code.wireshark.org/review/20799
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  4384591   kpasswd: remove unused entry hf_kpasswd_newpassword
    adds  b9b5703   Qt: Remember exact position of selected item in tree


Summary of changes:
 ui/qt/proto_tree.cpp |   48 +++++++++++++++++++++++++++++++++++++++++++++---
 1 file changed, 45 insertions(+), 3 deletions(-)