Wireshark-commits: [Wireshark-commits] master-2.2 c94b1f5: Qt: fix tracer and selection of packet i
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 5 Apr 2017 14:03:09 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c94b1f5cce521378cbbd3301d078b6b8f79f093d
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master-2.2
Repository: wireshark

Commits:

c94b1f5 by Peter Wu (peter@xxxxxxxxxxxxx):

    Qt: fix tracer and selection of packet in IO Graph
    
    Do not assume first graph in the list, pick the first visible graph.
    This (1) fixes the tracer which would otherwise show a marker at an
    non-obvious position that is not located on the graph and (2) fixes the
    GoToPacket action when clicking on the graph.
    
    Bug: 13537
    Change-Id: I49d750102ad25c8539aa2e44fe1583cd535dd471
    Reviewed-on: https://code.wireshark.org/review/20768
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    (cherry picked from commit a5f9b4e06dffa34e795f3abb1e44d4e7ec7cdfa9)
     [Conflicts resolved by replacing use of VariantPointer -- PeterWu]
    Reviewed-on: https://code.wireshark.org/review/20925
    

Actions performed:

    from  c5adb50   Bluetooth: HCI_CMD: Fix wrong field name
    adds  c94b1f5   Qt: fix tracer and selection of packet in IO Graph


Summary of changes:
 ui/qt/io_graph_dialog.cpp |   40 +++++++++++++++++++++++++++++++---------
 ui/qt/io_graph_dialog.h   |    1 +
 2 files changed, 32 insertions(+), 9 deletions(-)