Wireshark-commits: [Wireshark-commits] master 76edea1: Bluetooth: HCI_CMD: Fix master-slave role
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 5 Apr 2017 07:05:58 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=76edea174f808785cca55033cb3c2ebfbf149e6a
Submitter: Michal Labedzki (michal.labedzki@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

76edea1 by Michal Labedzki (michal.labedzki@xxxxxxxxx):

    Bluetooth: HCI_CMD: Fix master-slave role
    
    Initiator is always master. Only Role switch event may change it.
    Improve "Accept Connection Request" to avoid users confusion
    by using new specification description:
    0x00 Become the Master for this connection. The LM will perform the role switch.
    0x01 Remain the Slave for this connection. The LM will NOT perform the role switch.
    
    Field "Role" is now splitted from: "bthci_cmd.role"
    and it name is "bthci_cmd.acr.role".
    
    Change-Id: I98e3641b9ba9d2fd6c97808e4772beb4265018fd
    Reviewed-on: https://code.wireshark.org/review/20894
    Petri-Dish: Michal Labedzki <michal.labedzki@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michal Labedzki <michal.labedzki@xxxxxxxxxxxxx>
    

Actions performed:

    from  cf54564   packet-geneve.c: Convert print_flags to proto_tree_add_bitmask
    adds  76edea1   Bluetooth: HCI_CMD: Fix master-slave role


Summary of changes:
 epan/dissectors/packet-bthci_cmd.c |   23 ++++++++++++++---------
 1 file changed, 14 insertions(+), 9 deletions(-)