Wireshark-commits: [Wireshark-commits] master d99112d: Use col_append_str() for fixed strings
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 3 Apr 2017 05:32:45 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d99112d39310c38798aae92a6db811d363ffc385
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

d99112d by Stig Bjørlykke (stig@xxxxxxxxxxxxx):

    Use col_append_str() for fixed strings
    
    Change from col_append_fstr() to col_append_str() when
    appending strings without formatting.
    
    Change-Id: I8975704c246f2b9a1301ed5f96273aa9d61c6f44
    Reviewed-on: https://code.wireshark.org/review/20857
    Petri-Dish: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  a344452   GTPv2: fix dissection of TWAN PLMN-ID
    adds  d99112d   Use col_append_str() for fixed strings


Summary of changes:
 epan/dissectors/asn1/cmip/cmip.cnf        |    4 ++--
 epan/dissectors/asn1/h245/h245.cnf        |    2 +-
 epan/dissectors/packet-artnet.c           |    2 +-
 epan/dissectors/packet-bthci_cmd.c        |    2 +-
 epan/dissectors/packet-bthci_vendor.c     |    4 ++--
 epan/dissectors/packet-bthfp.c            |    2 +-
 epan/dissectors/packet-bthsp.c            |    2 +-
 epan/dissectors/packet-btmcap.c           |    6 +++---
 epan/dissectors/packet-btsdp.c            |    6 +++---
 epan/dissectors/packet-c15ch.c            |   31 ++++++++++++++---------------
 epan/dissectors/packet-catapult-dct2000.c |    4 ++--
 epan/dissectors/packet-cmip.c             |    4 ++--
 epan/dissectors/packet-elmi.c             |    2 +-
 epan/dissectors/packet-gmr1_rach.c        |    4 ++--
 epan/dissectors/packet-gvcp.c             |    8 ++++----
 epan/dissectors/packet-h245.c             |    2 +-
 epan/dissectors/packet-hci_h4.c           |    2 +-
 epan/dissectors/packet-hdcp2.c            |    2 +-
 epan/dissectors/packet-hl7.c              |    2 +-
 epan/dissectors/packet-idrp.c             |    2 +-
 epan/dissectors/packet-opensafety.c       |    4 ++--
 epan/dissectors/packet-pcep.c             |    2 +-
 epan/dissectors/packet-rpcap.c            |    2 +-
 epan/dissectors/packet-s7comm.c           |   20 +++++++++----------
 epan/dissectors/packet-u3v.c              |    6 +++---
 epan/dissectors/packet-usb-hid.c          |   16 +++++++--------
 epan/dissectors/packet-wai.c              |    2 +-
 epan/dissectors/packet-ypserv.c           |    2 +-
 28 files changed, 73 insertions(+), 74 deletions(-)