Wireshark-commits: [Wireshark-commits] master f998923: BGP: Remove redundant text in Path Attribute
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f998923bae797556106e36826dbb900c71276c1a
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
f998923 by Simon Zhong (szhong.jnpr@xxxxxxxxx):
BGP: Remove redundant text in Path Attributes.
Also added display of lower-order four bits of the Attribute Flags ("unused").
Current implementation of displaying path attribute flags shows flag description twice if the flag was set.
For example, with Optional and Length set, the attribute flags were displayed as follows:
Flags: 0x90, Optional, Length: Optional, Non-transitive, Complete, Extended Length
1... .... = Optional: Optional
.0.. .... = Transitive: Non-transitive
..0. .... = Partial: Complete
...1 .... = Length: Extended length
Now they are displayed as follows:
Flags: 0x90, Optional, Extended-Length, Non-transitive, Complete
1... .... = Optional: Set
.0.. .... = Transitive: Not set
..0. .... = Partial: Not set
...1 .... = Extended-Length: Set
.... 0000 = Unused: 0x0
Change-Id: Iec3c92ac2383dd3f736598b089a74f0f3c165bae
Reviewed-on: https://code.wireshark.org/review/20732
Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
Actions performed:
from 7a1679b ACN with blobs and magic bullet
adds f998923 BGP: Remove redundant text in Path Attributes.
Summary of changes:
epan/dissectors/packet-bgp.c | 27 +++++++++++++++++----------
1 file changed, 17 insertions(+), 10 deletions(-)
