Wireshark-commits: [Wireshark-commits] master-2.0 c4070d1: isns: fix dead code
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 1 Apr 2017 19:34:28 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c4070d12f7a1abc36ab131abb65850f1da27f348
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

c4070d1 by Martin Kaiser (wireshark@xxxxxxxxx):

    isns: fix dead code
    
    do the special handling for len==0 and tag==ISNS_ATTR_TAG_PORTAL_GROUP_TAG
    before going into the different attributes
    
    Bug: 12503
    Change-Id: I4dd6dcea25aba2e4963811a7a85f1eed1b906bcd
    Reviewed-on: https://code.wireshark.org/review/15875
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 3fe879b88e53f3388653dde9a4631b45ca7290c7)
    Reviewed-on: https://code.wireshark.org/review/20842
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  6a0164d   Improve the display of metrics.
    adds  c4070d1   isns: fix dead code


Summary of changes:
 epan/dissectors/packet-isns.c |   18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)