Wireshark-commits: [Wireshark-commits] master 38bc42b: Fix IPv6/IPX statistics generation
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 1 Apr 2017 10:28:38 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=38bc42b00b21866d8c2161830876fce0aab426ee
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

38bc42b by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    Fix IPv6/IPX statistics generation
    
    g70381f7 switched from a sorted GSList to a wmem_tree.
    But the strings "ipx" or "ipv6" must be tested before "ip" to select the
    right tap so the sorting does matter.
    Use a wmem_list and parse it by reverse order like what was done with
    the GSList to ensure proper selection of the tap.
    
    Change-Id: Ic8d291c265e9c83c960d9a2f6713c25e3aa0e60d
    Reviewed-on: https://code.wireshark.org/review/20813
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    

Actions performed:

    from  420da27   Add DirectPlay 8 Enumation Query/Response packets
    adds  38bc42b   Fix IPv6/IPX statistics generation


Summary of changes:
 epan/stat_tap_ui.c |   66 ++++++++++++++++++++++++++++++----------------------
 1 file changed, 38 insertions(+), 28 deletions(-)