Wireshark-commits: [Wireshark-commits] master-2.2 545e648: Fix some dissection errors.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 1 Apr 2017 03:48:42 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=545e6483dd0ca3125ee5fe620cfbe32415c7766d
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.2
Repository: wireshark

Commits:

545e648 by Guy Harris (guy@xxxxxxxxxxxx):

    Fix some dissection errors.
    
    "XXX supported" for a metric type is a Boolean, not an int; add it as
    such.
    
    Add the value of the item without the extra bits.
    
    The length of an address prefix is in semi-octets (nibbles/hex digits),
    not in octets.
    
    Change-Id: I642f0dab5030f7609e89f45cf2cff15cd74dfbda
    Reviewed-on: https://code.wireshark.org/review/20819
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 02f74e47ed3e542f4aff9fc6a7a9c44e29be5c7b)
    Reviewed-on: https://code.wireshark.org/review/20830
    

Actions performed:

    from  879d976   You can't get a string value from an FT_NONE string.
    adds  545e648   Fix some dissection errors.


Summary of changes:
 epan/dissectors/packet-isis-lsp.c |   17 ++++++++-----
 epan/osi-utils.c                  |   51 +++++++++++++++++++++++++++++--------
 epan/osi-utils.h                  |    1 +
 3 files changed, 51 insertions(+), 18 deletions(-)