Wireshark-commits: [Wireshark-commits] master 19bb1b1: Provide better error messages for field type
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 1 Apr 2017 02:42:52 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=19bb1b128b0e8fdbff0959a00ea062a34fbadfb4
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

19bb1b1 by Guy Harris (guy@xxxxxxxxxxxx):

    Provide better error messages for field type mismatches.
    
    Don't just report an assertion failure with a line in proto.c; give the
    name of the field with the wrong type, and a list of the types that are
    valid for the routine in question.
    
    Change-Id: Id3ed7c376fdc72bf6cff69c647833946cfa99ee6
    Reviewed-on: https://code.wireshark.org/review/20824
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  d967d71   FT_CHAR is an integral type, so list it in the diagnostic message.
    adds  19bb1b1   Provide better error messages for field type mismatches.


Summary of changes:
 epan/proto.c |   24 ++++++++++++++++++------
 1 file changed, 18 insertions(+), 6 deletions(-)