Wireshark-commits: [Wireshark-commits] master 93e7103: TLS: add bare essentials for TLS 1.3 decrypt
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 31 Jan 2017 04:47:39 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=93e71032418045884280c7d081da2d6c0030985c
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

93e7103 by Peter Wu (peter@xxxxxxxxxxxxx):

    TLS: add bare essentials for TLS 1.3 decryption support
    
    The bare essentials are now in place to perform decryption
    (HKDF-Expand-Label, calculation of traffic secrets, AEAD integration).
    Can successfully decrypt the initial handshake message. Only AES ciphers
    are supported, ChaCha20-Poly1305 still needs to be added.
    
    Note: "decryption" indeed works, but dissection needs to be updated. The
    padding must be stripped and the content type extracted.
    
    Ping-Bug: 12779
    Change-Id: I3869c9ae5131e57519be99c5f439c4fa68841bae
    Reviewed-on: https://code.wireshark.org/review/19858
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  17b98fe   ssl-utils: add AEAD authentication check
    adds  93e7103   TLS: add bare essentials for TLS 1.3 decryption support


Summary of changes:
 epan/dissectors/packet-ssl-utils.c |  285 +++++++++++++++++++++++++++++++++++-
 epan/dissectors/packet-ssl-utils.h |   19 +++
 epan/dissectors/packet-ssl.c       |   12 ++
 3 files changed, 310 insertions(+), 6 deletions(-)