Wireshark-commits: [Wireshark-commits] master b3035df: (D)TLS: fix type of record sequence number
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 29 Jan 2017 23:31:58 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b3035df88796e0e9058b315791861b03b3b59af7
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

b3035df by Peter Wu (peter@xxxxxxxxxxxxx):

    (D)TLS: fix type of record sequence number
    
    The record sequence number is 64-bit, not 32-bit. This applies to all
    SSLv3/TLS/DTLS versions. Without this fix, after about four million
    records, the wrong MAC is calculated (for TLS 1.2) or decryption will
    fail (for TLS 1.3).
    
    Change-Id: I05e5e8bc4229ac443a1b06c5fe984fb885eab1ca
    Reviewed-on: https://code.wireshark.org/review/19824
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  9fb9bc5   Use g_list_prepend, it's more efficient.
    adds  b3035df   (D)TLS: fix type of record sequence number


Summary of changes:
 epan/dissectors/packet-dtls.c      |    4 ++--
 epan/dissectors/packet-ssl-utils.c |   24 ++++++------------------
 epan/dissectors/packet-ssl-utils.h |    2 +-
 epan/dissectors/packet-ssl.c       |    5 +++--
 wsutil/pint.h                      |   11 +++++++++++
 5 files changed, 23 insertions(+), 23 deletions(-)