Wireshark-commits: [Wireshark-commits] master 8f81dd4: TLS: fix decryption of renegotiated sessions
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 28 Jan 2017 15:41:24 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8f81dd4f8274c2bd9b8438a59cbe232c09f5e573
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

8f81dd4 by Peter Wu (peter@xxxxxxxxxxxxx):

    TLS: fix decryption of renegotiated sessions
    
    Renegotiated sessions may interleave application data with handshake
    records. These handshake records should however not be included in the
    flow associated with the application data. This fixes a regression in
    the previous patch, now the "1.12 Step: SSL Decryption (renegotiation)"
    test passes again.
    
    Also remove duplicate DTLS data sources for decrypted records.
    
    Change-Id: I46d416ffba11a7c25c5a682b3b53f06d10d4ab79
    Fixes: v2.3.0rc0-2152-g77404250d5 ("(D)TLS: consolidate and simplify decrypted records handling")
    Reviewed-on: https://code.wireshark.org/review/19822
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  0ce7b55   qsig: Remove unnecessary hash table functionality
    adds  8f81dd4   TLS: fix decryption of renegotiated sessions


Summary of changes:
 epan/dissectors/packet-dtls.c      |    3 ---
 epan/dissectors/packet-ssl-utils.c |    7 ++++++-
 2 files changed, 6 insertions(+), 4 deletions(-)