Wireshark-commits: [Wireshark-commits] master-2.2 262da1c: prefs: Preserve UTF-8 characters in pref
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 28 Jan 2017 03:51:45 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=262da1c6c00be3774ed7794b64bd8628270bc2f9
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master-2.2
Repository: wireshark

Commits:

262da1c by Stig Bjørlykke (stig@xxxxxxxxxxxxx):

    prefs: Preserve UTF-8 characters in preferences.
    
    When saving preferences the strings in string lists must not be
    escaped with g_strescape() because this will destroy UTF-8 characters.
    
    Because this strings only should use printable characters we manually
    escape quote and backslash, and skip non-printable.
    
    Bug: 13342
    Change-Id: I57e492dff746a5ecc0aee809f946a615ad110b4d
    Reviewed-on: https://code.wireshark.org/review/19738
    Petri-Dish: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 7f4d8491f32a0bb8ea37376443429e162ea6cd86)
    Reviewed-on: https://code.wireshark.org/review/19814
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  a1d434d   ldss: Ensure ldss_file_request_t structure gets allocated
    adds  262da1c   prefs: Preserve UTF-8 characters in preferences.


Summary of changes:
 epan/prefs.c |   18 ++++++++++++++----
 1 file changed, 14 insertions(+), 4 deletions(-)