Wireshark-commits: [Wireshark-commits] master dc86242: ssl-utils: recognize new TLS 1.3 keylog form
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 27 Jan 2017 05:02:00 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=dc86242e3e158adbc99371acf4c99d4e06e57a1a
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

dc86242 by Peter Wu (peter@xxxxxxxxxxxxx):

    ssl-utils: recognize new TLS 1.3 keylog format
    
    Implemented by BoringSSL, an older description can be found at:
    https://github.com/google/boringssl/commit/e776cc29568e520aaabc83188cc7db7991f0b776
    
    Implementation pending at OpenSSL:
    https://github.com/openssl/openssl/pull/2287
    
    NSS bug (still open):
    https://bugzilla.mozilla.org/show_bug.cgi?id=1287711
    
    Proposal for PicoTLS:
    https://github.com/h2o/picotls/issues/6
    
    Change-Id: Ib597f48e296d286d8f6d30873ca03e7d6324a3c4
    Ping-Bug: 12779
    Reviewed-on: https://code.wireshark.org/review/19801
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  9f60038   sharkd: fix potential division-by-zero issue
    adds  dc86242   ssl-utils: recognize new TLS 1.3 keylog format


Summary of changes:
 epan/dissectors/packet-ssl-utils.c |   39 +++++++++++++++++++++++++++++++++---
 epan/dissectors/packet-ssl-utils.h |    6 ++++++
 2 files changed, 42 insertions(+), 3 deletions(-)