Wireshark-commits: [Wireshark-commits] master 1157420: Clean up EVPN NLRIs dissection.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 25 Jan 2017 03:43:09 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=11574208e7f11d76bb1dbe460577396b8c06e3fb
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

1157420 by Guy Harris (guy@xxxxxxxxxxxx):

    Clean up EVPN NLRIs dissection.
    
    Do the NLRI length checks in the switch cases for each route type, and
    do them for *all* route types, rather than throwing a random check in
    for one particular route type.
    
    There is no need to fail up front for unknown route types; at least
    dissect the type and length, and fail in the switch statement.
    
    Dissect the route descriptor in each of the switch cases, after the
    length check, rather than doing it up front.
    
    Add a comment noting where the prefix route type comes from.
    
    Change-Id: Iae26ecd467d4b36dbcf52e7998bd2881405281aa
    Reviewed-on: https://code.wireshark.org/review/19774
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  538b6fc   Add URL for the AoE spec.
    adds  1157420   Clean up EVPN NLRIs dissection.


Summary of changes:
 epan/dissectors/packet-bgp.c |  118 +++++++++++++++++++++++++++++++++---------
 1 file changed, 93 insertions(+), 25 deletions(-)