Wireshark-commits: [Wireshark-commits] master-2.2 f291d1f: DHCPv6: Avoid integer overflows.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 23 Jan 2017 19:23:16 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f291d1f0f50a0aeaa0e8d85a8c03d42e4f3e8d32
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master-2.2
Repository: wireshark

Commits:

f291d1f by Gerald Combs (gerald@xxxxxxxxxxxxx):

    DHCPv6: Avoid integer overflows.
    
    Count using ints instead of guint16s.
    
    Make sure dissect_packetcable_ccc_option and
    dissect_packetcable_cccV6_option return positive values while we're
    here.
    
    Bug: 13345
    Change-Id: Ic303ddc266f46ee3144e079731742c85808faf37
    Reviewed-on: https://code.wireshark.org/review/19747
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    (cherry picked from commit 57894f741f7cc98b46c9fdce7eee8256d2a4ae3f)
    Reviewed-on: https://code.wireshark.org/review/19750
    

Actions performed:

    from  bb235f1   ASTERIX: Avoid an integer overflow.
    adds  f291d1f   DHCPv6: Avoid integer overflows.


Summary of changes:
 epan/dissectors/packet-dhcpv6.c |   18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)