Wireshark-commits: [Wireshark-commits] master c38f2be: Qt: Fix a sequence dialog crash.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 20 Jan 2017 02:26:03 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c38f2be9907eb24d50ac29e9bd9c4c3e54805979
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

c38f2be by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Qt: Fix a sequence dialog crash.
    
    If gui.geom.SequenceDialog.maximized is TRUE, loadGeometry will trigger
    a resize event, which will in turn call resetAxes. Call loadGeometry
    after we've initialized our various QCustomPlot bits so that resetAxes
    doesn't crash.
    
    Bug: 13329
    Change-Id: I4d27683fb3eee0a7c897800401bfa3869e97662b
    Reviewed-on: https://code.wireshark.org/review/19683
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  96f07a0   Fix typo.
    adds  c38f2be   Qt: Fix a sequence dialog crash.


Summary of changes:
 ui/qt/sequence_dialog.cpp |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)