Wireshark · Wireshark-commits: [Wireshark-commits] master 73b5e3d: Qt: modify RTT graph (handle GSO, SACK, etc), plus bug fixes

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=73b5e3d0082cc7ca65e5a085bd80264e5a0b1082
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

73b5e3d by Kevin Hogan (kwabena@xxxxxxxxxx):

    Qt: modify RTT graph (handle GSO, SACK, etc), plus bug fixes
    
    Modifications to RTT graph:
     - change x-axis to time (s) rather than sequence number
        [ avoids sequence number wraparound ambiguity, plus
           easier to correlate RTT changes to tcptrace graph ]
     - change RTT computation to properly handle acks to GSO packets
     - change RTT computation to take SACK blocks into account
    
    Bug fixes:
     - eliminate potential memory leak if some packets are unacked
     - ensure RTT graph is shown if TCPGraph window is opened to it directly
    
    Change-Id: I2bdcab97399ebde0f15c78fa19c882529a814580
    Reviewed-on: https://code.wireshark.org/review/19662
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  069a532   LDAP: fix wrong use of g_strlcpy introduced in gc397add
    adds  73b5e3d   Qt: modify RTT graph (handle GSO, SACK, etc), plus bug fixes


Summary of changes:
 ui/gtk/tcp_graph.c          |   55 ++++++++++-----
 ui/qt/tcp_stream_dialog.cpp |  165 ++++++++++++++++++++++++++++++++++++-------
 ui/qt/tcp_stream_dialog.h   |    1 -
 ui/tap-tcp-stream.c         |   31 +++++---
 ui/tap-tcp-stream.h         |   29 ++++++--
 5 files changed, 224 insertions(+), 57 deletions(-)