Wireshark · Wireshark-commits: [Wireshark-commits] master 86c4808: DVB-S2-BB: Obey frame format from BB Header fields

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=86c4808518b4a3929f2bdc4b6bab59b87b67b6bd
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

86c4808 by MustBeArt (paul@xxxxxxxxxxxxx):

    DVB-S2-BB: Obey frame format from BB Header fields
    
    Interpret packet contents according to the descriptive fields contained
    in the BB header. Instead of always assuming a Generic Stream frame format,
    use the TS/GS field to detect Generic Stream, Generic Packetized, Transport
    Stream, or (reserved) frame formats and decode accordingly.
    
    In the case of Generic Stream frames, check the validity of header fields
    ISSYI, NPD, and UPL, and issue expert info if they are invalid for Generic
    Stream frames. Then dissect as GSE (as before).
    
    For other frame formats, just dump them as bytes for now.
    
    Change-Id: I6b040207f83369110eb704c543861c887f77baa7
    Reviewed-on: https://code.wireshark.org/review/19634
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  d691b0e   Remove space character from ETHERWATCH magic key
    adds  86c4808   DVB-S2-BB: Obey frame format from BB Header fields


Summary of changes:
 epan/dissectors/packet-dvb-s2-bb.c |  108 +++++++++++++++++++++++++++++-------
 1 file changed, 88 insertions(+), 20 deletions(-)