Wireshark-commits: [Wireshark-commits] master c397add: dns: change get_dns_name to return consumed
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c397adda8a7af8374ba1355f8c221f48abfac42a
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
c397add by Dario Lombardo (lomato@xxxxxxxxx):
dns: change get_dns_name to return consumed bytes + actual name len.
Because of the DNS name encoding, the consumed bytes in the tvb and
the length of the string of the dns name can be different. We need
to handle them separately for the purpose they are. Moreover the
name string can contain null bytes, then we can't rely on strlen()
but we need the actual length.
Subsequent calls to proto_tree_add_string() will require to pass
the string to format_text() in order have non-printable characters
printed.
Bug: 13289
Change-Id: I6d0b295867ece265f8995f82da2c629992aeb703
Reviewed-on: https://code.wireshark.org/review/19539
Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
Petri-Dish: Dario Lombardo <lomato@xxxxxxxxx>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
Actions performed:
from a056b68 pcep: Add support of draft-ietf-pce-pcep-service-aware-13
adds c397add dns: change get_dns_name to return consumed bytes + actual name len.
Summary of changes:
epan/dissectors/asn1/ldap/packet-ldap-template.c | 5 +-
epan/dissectors/packet-bootp.c | 23 +-
epan/dissectors/packet-dns.c | 319 +++++++++++-----------
epan/dissectors/packet-dns.h | 4 +-
epan/dissectors/packet-icmpv6.c | 23 +-
epan/dissectors/packet-ldap.c | 9 +-
epan/dissectors/packet-lwres.c | 38 +--
epan/dissectors/packet-nbt.c | 8 +-
epan/dissectors/packet-smb-common.c | 6 +-
9 files changed, 228 insertions(+), 207 deletions(-)
