Wireshark-commits: [Wireshark-commits] master 7f52ff0: RSVD dissector: added RSVD v2 verbs
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 19 Jan 2017 04:56:16 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7f52ff06a4c40661c3c57a33bfe499589de8d0ca
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

7f52ff0 by Volodymyr Khomenko (Khomenko.Volodymyr@xxxxxxxxx):

    RSVD dissector: added RSVD v2 verbs
    
    Improved operation_code map to resolve RSVD v2 codes.
    Changed GET_FILE_INFO -> GET_INITIAL_INFO for spec conformance.
    See https://msdn.microsoft.com/en-us/library/dn392322.aspx
    
    SMB2 IOCTL FSCTL_SVHDX_ASYNC_TUNNEL_REQUEST must be handled in the same way as FSCTL_SVHDX_SYNC_TUNNEL_REQUEST:
    RSVD dissector must be used (new async flow used by RSVDv2).
    See https://msdn.microsoft.com/en-us/library/dn366375.aspx
    
    Ping-Bug: 11232
    Change-Id: Ie51773fc2199a7674538101b87cec398354bd97a
    Reviewed-on: https://code.wireshark.org/review/19657
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  3b6fe2b   Populate logcat year based on localtime
    adds  7f52ff0   RSVD dissector: added RSVD v2 verbs


Summary of changes:
 epan/dissectors/packet-rsvd.c |   55 ++++++++++++++++++++++++-----------------
 epan/dissectors/packet-smb2.c |    2 ++
 2 files changed, 35 insertions(+), 22 deletions(-)