Wireshark-commits: [Wireshark-commits] master d04b5cd: Use dissector tables for PPP protocols' opti
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 19 Jan 2017 04:33:15 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d04b5cd362be82bf685fde65af67e73c5a8ca0e4
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

d04b5cd by Michael Mann (mmann78@xxxxxxxxxxxx):

    Use dissector tables for PPP protocols' options.
    
    Create pinos for all of the PPP protocols options and a dissector table to store
    them all.  Adapt a new version of dissect_ip_tcp_options, (now ppp_dissect_options)
    that uses the dissector tables for name of options and dissection function.
    Also standardize the dissectors for all protocols so that all include type and
    length in the dissection.
    
    Change-Id: I0033574e2831789040a1ce2857bf0e825d791cbe
    Reviewed-on: https://code.wireshark.org/review/19656
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  37f4e42   packet: free postseq_cleanup_routines list.
    adds  d04b5cd   Use dissector tables for PPP protocols' options.


Summary of changes:
 debian/libwireshark0.symbols |    1 +
 epan/dissectors/packet-ppp.c | 3115 ++++++++++++++++++++++++++----------------
 epan/unit_strings.c          |    1 +
 epan/unit_strings.h          |    1 +
 4 files changed, 1944 insertions(+), 1174 deletions(-)