Wireshark-commits: [Wireshark-commits] master 3df81a0: Qt: Remove unneccessary Q_DECLARE_METATYPE
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 12 Jan 2017 16:04:28 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3df81a055064e2e2c8c9548f1c6837ddef5e5034
Submitter: Roland Knall (rknall@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

3df81a0 by Roland Knall (roland.knall@xxxxxxxxxxxxxxxxx):

    Qt: Remove unneccessary Q_DECLARE_METATYPE
    
    Remove unnecessary Q_DECLARE_METATYPE macros and replace calls
    to QVariant conversions with VariantPointer where necessary
    
    Change-Id: Ia4690590095f930bf94644197de7fa30b00ee7ec
    Reviewed-on: https://code.wireshark.org/review/19611
    Petri-Dish: Roland Knall <rknall@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    

Actions performed:

    from  d6d5168   Diameter: decode Emergency-Indication AVP (1538)
    adds  3df81a0   Qt: Remove unneccessary Q_DECLARE_METATYPE


Summary of changes:
 ui/qt/bluetooth_device_dialog.cpp                  |   23 +++-----
 ui/qt/bluetooth_device_dialog.h                    |    7 +++
 ui/qt/bluetooth_devices_dialog.cpp                 |   21 +++----
 ui/qt/bluetooth_hci_summary_dialog.cpp             |   44 +++++++--------
 ui/qt/byte_view_tab.cpp                            |    6 +-
 ui/qt/byte_view_text.cpp                           |    4 +-
 ui/qt/conversation_dialog.h                        |    2 -
 ui/qt/decode_as_dialog.cpp                         |    8 ++-
 ui/qt/display_filter_expression_dialog.cpp         |    8 +--
 ui/qt/endpoint_dialog.h                            |    2 -
 ui/qt/extcap_argument.h                            |    3 -
 ui/qt/extcap_options_dialog.cpp                    |    9 +--
 ui/qt/file_set_dialog.cpp                          |    8 +--
 ui/qt/io_graph_dialog.cpp                          |   27 +++++----
 ui/qt/main_window.cpp                              |    4 --
 ui/qt/main_window.h                                |    3 +
 ui/qt/main_window_slots.cpp                        |   20 +++----
 ui/qt/module_preferences_scroll_area.cpp           |   58 ++++++++++----------
 ui/qt/preferences_dialog.cpp                       |   29 +++++++---
 ui/qt/profile_dialog.cpp                           |   22 ++++----
 ui/qt/proto_tree.cpp                               |   24 ++++----
 ui/qt/proto_tree.h                                 |    2 -
 ui/qt/protocol_hierarchy_dialog.cpp                |    9 +--
 ui/qt/rtp_player_dialog.cpp                        |    3 -
 ui/qt/sparkline_delegate.h                         |    2 +-
 ui/qt/stats_tree_dialog.cpp                        |   12 ++--
 .../packet-chdlc.h => ui/qt/variant_pointer.h      |   37 +++++++------
 ui/qt/voip_calls_dialog.cpp                        |    2 -
 ui/qt/wireless_frame.cpp                           |    1 -
 29 files changed, 198 insertions(+), 202 deletions(-)
 copy epan/dissectors/packet-chdlc.h => ui/qt/variant_pointer.h (65%)