Wireshark-commits: [Wireshark-commits] master f8dc234: Qt: fix memleak of PointList in interface st
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 12 Jan 2017 13:41:33 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f8dc2346dfa5df67749583a428f9a76b2f61acb1
Submitter: Roland Knall (rknall@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

f8dc234 by Peter Wu (peter@xxxxxxxxxxxxx):

    Qt: fix memleak of PointList in interface statistics
    
    The list of points (for interface traffic statistics) is part of the
    interface tree model/view. Remove the pointer indirection to simplify
    cleanup and avoid leaking a PointList.
    
    Note that the SparkLineDelegate is used in two different places
    (CaptureInterfacesDialog and InterfaceTreeModel).
    
    Change-Id: I5fef7dadd44fdf58c07844fee269f509c712a36f
    Reviewed-on: https://code.wireshark.org/review/19606
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    

Actions performed:

    from  4b3b3f5   Extcap: Restore previously created preference from hash table, not preference pointer
    adds  f8dc234   Qt: fix memleak of PointList in interface statistics


Summary of changes:
 ui/qt/capture_interfaces_dialog.cpp |   18 +++++++++---------
 ui/qt/interface_tree_model.cpp      |   13 ++-----------
 ui/qt/interface_tree_model.h        |    2 +-
 ui/qt/sparkline_delegate.cpp        |   12 ++++++------
 4 files changed, 18 insertions(+), 27 deletions(-)