Wireshark-commits: [Wireshark-commits] master 0ecfc72: Use tvb_new_subset_remaining() rather than t
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 10 Jan 2017 06:41:12 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0ecfc7280cf3d793a754722b27692216e5a2986f
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

0ecfc72 by Guy Harris (guy@xxxxxxxxxxxx):

    Use tvb_new_subset_remaining() rather than tvb_new_subset_length_caplen().
    
    Any call of the form tvb_new_subset_length_caplen(tvb, offset, -1, -1)
    should instead be tvb_new_subset_remaining(tvb, offset).
    
    Change-Id: I4bc95b028103ea4fc82453ef3460c147d7ccabd6
    Reviewed-on: https://code.wireshark.org/review/19598
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  7cd6906   Rename tvb_new_subset() to tvb_new_subset_length_caplen().
    adds  0ecfc72   Use tvb_new_subset_remaining() rather than tvb_new_subset_length_caplen().


Summary of changes:
 docbook/wsdg_src/WSDG_chapter_dissection.asciidoc |    4 +--
 epan/dissectors/packet-c15ch.c                    |    6 ++--
 epan/dissectors/packet-dof.c                      |   36 ++++++++++-----------
 epan/dissectors/packet-isi.c                      |    2 +-
 epan/dissectors/packet-ncp2222.inc                |    6 ++--
 5 files changed, 27 insertions(+), 27 deletions(-)