Wireshark-commits: [Wireshark-commits] master 6e29d87: Qt: fix crash on undecodable RTP stream
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 8 Jan 2017 02:49:08 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6e29d874f8b5e6ebc59f661a0bb0dab8e56f122a
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

6e29d87 by Peter Wu (peter@xxxxxxxxxxxxx):

    Qt: fix crash on undecodable RTP stream
    
    When the sample rate is zero, a floating point exception (FPE) occurs in
    QAudioDeviceInfo::nearestFormat. Detect the error condition instead and
    show an error.
    
    Change-Id: Ie2eaa57847938fe15607fa26d0f4e08e7ddd23d1
    Fixes: v2.3.0rc0-1664-gd59653f8d5 ("Qt: Make the RTP player output device selectable.")
    Reviewed-on: https://code.wireshark.org/review/19569
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  082ba06   Comments on the first nibble stuff.
    adds  6e29d87   Qt: fix crash on undecodable RTP stream


Summary of changes:
 ui/qt/rtp_audio_stream.cpp |    5 +++++
 ui/qt/rtp_player_dialog.h  |    5 ++++-
 2 files changed, 9 insertions(+), 1 deletion(-)