Wireshark-commits: [Wireshark-commits] master 165c8b0: Refactor range preference.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 7 Jan 2017 15:35:46 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=165c8b04227df05a0ae329e92adff7bd314b9d4b
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

165c8b0 by Michael Mann (mmann78@xxxxxxxxxxxx):

    Refactor range preference.
    
    Refactored so that all handling of ranges in struct preference
    can be internal to prefs.c
    
    Change-Id: I68577909f9c07b23a16ab3443a523355d4645314
    Reviewed-on: https://code.wireshark.org/review/19577
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  fb9ac50   DVB-S2 BB: Fix BB header CRC checks
    adds  165c8b0   Refactor range preference.


Summary of changes:
 epan/decode_as.c                         |    2 +-
 epan/prefs-int.h                         |   83 ++++++++
 epan/prefs.c                             |  330 +++++++++++++++++++++++++++++-
 ui/gtk/decode_as_dlg.c                   |    4 +-
 ui/preference_utils.c                    |  277 -------------------------
 ui/preference_utils.h                    |   46 -----
 ui/qt/decode_as_dialog.cpp               |    4 +-
 ui/qt/module_preferences_scroll_area.cpp |    8 +-
 ui/qt/preference_editor_frame.cpp        |    8 +-
 ui/qt/preferences_dialog.cpp             |   71 +------
 ui/qt/preferences_dialog.h               |    1 -
 ui/qt/protocol_preferences_menu.cpp      |   28 +--
 12 files changed, 423 insertions(+), 439 deletions(-)