Wireshark-commits: [Wireshark-commits] master 0dcbfab: Make column size sanity check more sensible.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 7 Jan 2017 07:05:50 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0dcbfab4265b4f494a7b162d2c34c99ed7994541
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

0dcbfab by Noel Power (noel.power@xxxxxxxx):

    Make column size sanity check more sensible.
    
    The existing sanity check on column_size makes incorrect assumptions
    about the size of the CTableColumn structure (which is an internal
    dissector structure that contains optional data). The sanity check
    test *always* fails. This change uses the minimum size of CTableColumn
    structure instead which should prevent excessive allocation during fuzz
    testing.
    
    Bug: 13299
    Change-Id: Id9fcbc15a4df4c74bb7576c6fdca1000890947fd
    Signed-off-by: Noel Power <noel.power@xxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/19566
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  ae5dbe1   Add support for RROCE(v2) over IPv4 (without UDP).
    adds  0dcbfab   Make column size sanity check more sensible.


Summary of changes:
 epan/dissectors/packet-mswsp.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)