Wireshark-commits: [Wireshark-commits] master 26430ff: Include extcap binaries in the count of thin
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 4 Jan 2017 22:11:11 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=26430ff647eff817aebdf7425f866f6d7f0f9860
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

26430ff by Guy Harris (guy@xxxxxxxxxxxx):

    Include extcap binaries in the count of things to point out during startup.
    
    The GTK+ version, at least, crashes if there are more "doing XXX..."
    items put up than the calculated count, so, now that we're putting up
    items for extcap binaries, we need to count the extcap binaries.
    
    Clean up some stuff we found doing this (indentation, a _U_ on something
    that's used).
    
    Change-Id: I1f88042b64ce4b9ae352de37689677c694e3770b
    Reviewed-on: https://code.wireshark.org/review/19549
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  f7124f6   Escape opening curly braces in gen-bugnote.
    adds  26430ff   Include extcap binaries in the count of things to point out during startup.


Summary of changes:
 extcap.c                 |   35 +++++++++++++++++++++++++++++++++--
 extcap.h                 |    4 ++++
 ui/gtk/about_dlg.c       |    6 ++++++
 ui/qt/splash_overlay.cpp |    9 ++++++++-
 4 files changed, 51 insertions(+), 3 deletions(-)