Wireshark-commits: [Wireshark-commits] master a2d6fb9: No reason not to use etype_vals for an Ether
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 4 Jan 2017 02:10:49 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a2d6fb94fcefb10d5ef4650c1582d8c06a278bd5
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

a2d6fb9 by Guy Harris (guy@xxxxxxxxxxxx):

    No reason not to use etype_vals for an Ethertype field.
    
    Maybe there was an issue on Windows back in the old days, when 1) we
    didn't have a shared libwireshark library from which to import functions
    and data variables and thus you couldn't get variables such as
    etype_vals in a plugin and 2) the Infiniband dissector was a plugin, but
    neither of those are the case any more.
    
    Change-Id: Id8b82886317bd36a32ad1e1591673623696d4808
    Reviewed-on: https://code.wireshark.org/review/19530
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  ab28624   Ensure that tcp.reassembled_in is added to the tree for first segment.
    adds  a2d6fb9   No reason not to use etype_vals for an Ethertype field.


Summary of changes:
 epan/dissectors/packet-infiniband.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)