Wireshark-commits: [Wireshark-commits] master 0e3841c: ISAKMP: add traffic selector subtree
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 28 Dec 2016 07:32:23 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0e3841c3dd5702cb399eafda8deafa3818c1b461
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

0e3841c by Mirko Parthey (mirko.parthey@xxxxxx):

    ISAKMP: add traffic selector subtree
    
    Create a new subtree for each traffic selector.
    
    Use the length field to find the next traffic selector
    rather than accumulating the individual TS field sizes.
    
    Split dissect_ts() to introduce separate offset variables.
    After adding the final field, do not advance offset again
    to avoid unused variable warnings.
    
    Change-Id: I9951662c1bb3958994162b25b70b43ec1da103a7
    Reviewed-on: https://code.wireshark.org/review/19440
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  c27ff1d   macosx: Update Read me first.rtf with some additional install/deinstall notes
    adds  0e3841c   ISAKMP: add traffic selector subtree


Summary of changes:
 epan/dissectors/packet-isakmp.c |  205 +++++++++++++++++++--------------------
 1 file changed, 100 insertions(+), 105 deletions(-)