Wireshark-commits: [Wireshark-commits] master d70d32e: CIP: More attribute updates 1. CIP Safety: S
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 21 Dec 2016 20:15:37 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d70d32edb9f3425cb3e93dd6ff4b3d676b1b8858
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

d70d32e by D. Ulis (daulis0@xxxxxxxxx):

    CIP: More attribute updates
    1. CIP Safety: SERCOS Safety Network Number attribute should be 6 bytes. Don't just use all remaining bytes
    2. Remove cip_byte_array type. The last remaining usage was #1 above and it really shouldn't be used in the future. Any attribute that would eat up all remaining bytes would have issues with Get Attribute List responses and Set Attribute List requests.
    3. Optional Attribute List: Display the attribute name if known.
    4. Port: Display Port Number name
    5. Port: Associated Communication Objects attribute
    
    Change-Id: I94d99bb1f07aa4b8c44949b2ffb5d75e72483459
    Reviewed-on: https://code.wireshark.org/review/19374
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  5b1b136   packet-rpcrdma: Fix Reply chunk selection size
    adds  d70d32e   CIP: More attribute updates 1. CIP Safety: SERCOS Safety Network Number attribute should be 6 bytes. Don't just use all remaining bytes 2. Remove cip_byte_array type. The last remaining usage was #1 above and it really shouldn't be used in the future. Any attribute that would eat up all remaining bytes would have issues with Get Attribute List responses and Set Attribute List requests. 3. Optional Attribute List: Display the attribute name if known. 4. Port: Display Po [...]


Summary of changes:
 epan/dissectors/packet-cip.c       |   65 +++++++++++++++++++++++++++++++-----
 epan/dissectors/packet-cip.h       |    1 -
 epan/dissectors/packet-cipsafety.c |    9 ++++-
 3 files changed, 64 insertions(+), 11 deletions(-)