Wireshark · Wireshark-commits: [Wireshark-commits] master 4c50e4b: Improve Infiniband heuristic subdissection.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4c50e4b5c4d794de3944c05bd8ce3ed778a13443
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

4c50e4b by Michael Mann (mmann78@xxxxxxxxxxxx):

    Improve Infiniband heuristic subdissection.
    
    Add preference in Infiniband dissector to distinguish between
    heuristic and non-heuristic dissection (that uses Decode As).
    Remove all of the preferences in the Infiniband subdissectors that
    tried to put in "manual" heuristics and direct users to just use
    Decode As.  Most subdissectors still kept some basic heuristics in
    their heuristic functions, but now also register with the Infiniband
    dissector table for "manually" forcing dissection with Decode As.
    
    Ping-Bug: 13259
    Change-Id: I20d56eee38887664b439e52ec5f5b8f962c45ef1
    Reviewed-on: https://code.wireshark.org/review/19362
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  caadaaf   Make EAPOL packet types into a dissector table.
    adds  4c50e4b   Improve Infiniband heuristic subdissection.


Summary of changes:
 epan/dissectors/packet-fcoib.c          |  198 ++++++++++-------------------
 epan/dissectors/packet-infiniband.c     |   55 +++++++-
 epan/dissectors/packet-infiniband_sdp.c |  208 ++++++++++---------------------
 epan/dissectors/packet-iser.c           |  142 ++++++---------------
 epan/dissectors/packet-rpcrdma.c        |   27 ++--
 epan/dissectors/packet-smb-direct.c     |   32 +++--
 epan/dissectors/packet-smcr.c           |   13 +-
 7 files changed, 257 insertions(+), 418 deletions(-)