Wireshark-commits: [Wireshark-commits] master 5f6732d: Qt: minor updates to TCP stream dialog and t
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 19 Dec 2016 06:05:21 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5f6732d74eb731f26d389f378567d2dfa532f24c
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

5f6732d by Kevin Hogan (kwabena@xxxxxxxxxx):

    Qt: minor updates to TCP stream dialog and throughput moving average
    
    The time-based moving average code should use a constant window size
      as the denominator when calculating throughput.
    Added QDoubleSpinbox widget to choose the time-based moving average size.
    Also added (optional) ability to select ACK (reverse) packets as well as data
      packets when clicking on the base graph.
      (useful, for example, when examining SACK or DSACK packets)
    Added CheckBox widget (with tooltip) for user to choose ACK selection
    
    Change-Id: Ib3ba4f9be9e30aa8f3088b0b2d48b4ca214f7cc3
    Reviewed-on: https://code.wireshark.org/review/19108
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  05b3c06   RTSP: Decode XML data in ED-137 messages
    adds  5f6732d   Qt: minor updates to TCP stream dialog and throughput moving average


Summary of changes:
 ui/qt/tcp_stream_dialog.cpp |  162 ++++++++++++++++++++++++++++++++++++++-----
 ui/qt/tcp_stream_dialog.h   |   11 ++-
 ui/qt/tcp_stream_dialog.ui  |   20 ++++++
 3 files changed, 175 insertions(+), 18 deletions(-)