Wireshark-commits: [Wireshark-commits] master 8efb7fe: Adjust proto_tree_add_xxx_format_value calls
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 16 Dec 2016 01:55:35 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8efb7fece1ffefd26dacd79f5ec8722c4e01e827
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

8efb7fe by Michael Mann (mmann78@xxxxxxxxxxxx):

    Adjust proto_tree_add_xxx_format_value calls to use unit string
    
    proto_tree_add_uint_format_value had the most use of unit strings, this
    patch handles all of the other proto_tree_add_xxx_format_value calls that
    could be better served using BASE_UNIT_STRING with a "unit string" in hf_ field.
    
    Added more "common" unit string values to unit_strings.[ch]
    
    Change-Id: I0fb680be781e10037eb7bd40dd21a9ee20c1fb1c
    Reviewed-on: https://code.wireshark.org/review/19288
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  d706f9c   Add symlinks to Wireshark binaries in Resources/bin, and point there.
    adds  8efb7fe   Adjust proto_tree_add_xxx_format_value calls to use unit string


Summary of changes:
 debian/libwireshark0.symbols                |    1 +
 epan/dissectors/packet-ieee80211-radio.c    |   14 +++------
 epan/dissectors/packet-ieee80211-radiotap.c |   18 +++++-------
 epan/dissectors/packet-ixveriwave.c         |   42 ++++++++++++---------------
 epan/dissectors/packet-osc.c                |   14 ++++-----
 epan/dissectors/packet-tcp.c                |    7 +++--
 epan/dissectors/packet-windows-common.c     |    4 +--
 epan/unit_strings.c                         |    1 +
 epan/unit_strings.h                         |    1 +
 9 files changed, 45 insertions(+), 57 deletions(-)