Wireshark-commits: [Wireshark-commits] master e6a9877: Improved parsing of sniffed homeplug-av data
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 15 Dec 2016 07:33:32 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e6a9877c7177978ff655d6f61d7540fb835ea165
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

e6a9877 by Nora Sandler (nsandler@xxxxxxxxxxxxxxxxxxxxxx):

    Improved  parsing of sniffed homeplug-av data
    
    This patch modifies the homeplug-av dissector to better decode sniffer data according to the IEEE 1901-2010 standard.
    The dissector now decodes MPDU variant fields correctly based on delimiter type, and decodes beacon MPDU payloads.
    There are some variable-length fields it doesn't handle yet.
    This patch should have no effect on how non-sniffer-data packets are decoded.
    These changes are based on Andrew Margolis' pull request to faifa at https://github.com/ffainelli/faifa/pull/11
    
    Change-Id: Ia60ac7affa99a68b38f04ab66373ac715c761328
    Reviewed-on: https://code.wireshark.org/review/19156
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  e1e6195   802.11(ad): fix wrong dissection of Grant Frame
    adds  e6a9877   Improved  parsing of sniffed homeplug-av data


Summary of changes:
 epan/dissectors/packet-homeplug-av.c | 1187 +++++++++++++++++++++++++++++-----
 1 file changed, 1041 insertions(+), 146 deletions(-)