Wireshark-commits: [Wireshark-commits] master 9090afb: Save RTP audio to file: RTP Stream Analysis
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9090afbfe9a4f9a422409c3f9d410bc3c14fc741
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
9090afb by Jiri Novak (j.novak@xxxxxxxxxxxx):
Save RTP audio to file: RTP Stream Analysis dialog allows save audio for non G.711 codecs and mixed codecs
- spaghetti code for save was split into separate functions
- code saves G.711 only, all other codecs are saved as silence with correct duration
- code is ready to include other codecs
- code supports 8000 Hz sampling rate only, other rates are rejected with warning
- bidirectional stream (forward and reverse) creates stereo .au file
- output is based on timestamps in RTP streams
- save operation is slower than before because it is set of seek() - one per each codec sample
- code allows align of save audio:
- as it is - each stream is saved from its beginning, no aling
- to start of each other - later stream is prepended with silence
- align saved audio to beginning of capture file - each stream is prepended with silence
- save to raw works correctly now - only payload is saved
- old code was inserting G.711 silence time to time to raw data
Bug: 13242
Change-Id: I74d02a1cc1c75acf9ffe930d078c00a0555cbfb6
Reviewed-on: https://code.wireshark.org/review/19245
Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
Actions performed:
from 1afbab6 Just use strncmp() to check the prefix of the file's first line.
adds 9090afb Save RTP audio to file: RTP Stream Analysis dialog allows save audio for non G.711 codecs and mixed codecs
Summary of changes:
ui/qt/rtp_analysis_dialog.cpp | 711 ++++++++++++++++++++++++-----------------
ui/qt/rtp_analysis_dialog.h | 22 +-
ui/qt/rtp_analysis_dialog.ui | 66 +++-
ui/tap-rtp-analysis.h | 7 +
ui/tap-rtp-common.c | 11 +-
wsutil/pint.h | 3 +
6 files changed, 514 insertions(+), 306 deletions(-)
