Wireshark-commits: [Wireshark-commits] master b7f4e25: Adjust proto_tree_add_uint_format_value call
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 13 Dec 2016 22:58:05 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b7f4e250599d7ea0452711d388c161fd4ef61c60 Submitter: Michael Mann (mmann78@xxxxxxxxxxxx) Changed: branch: master Repository: wireshark Commits: b7f4e25 by Michael Mann (mmann78@xxxxxxxxxxxx): Adjust proto_tree_add_uint_format_value calls to use unit string Several calls to proto_tree_add_uint_format_value could be better served using BASE_UNIT_STRING with a "unit string" in hf_ field. There also a few cases where proto_tree_add_uint_format_value could just be proto_tree_add_uint. Added a few more "common" unit string values to unit_strings.[ch] Change-Id: Iaedff82c515269c9c31ab9100dff19f5563c932d Reviewed-on: https://code.wireshark.org/review/19242 Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx> Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx> Actions performed: from a869ec6 Adjust proto_tree_add_[float|double]_format_value calls to use unit string adds b7f4e25 Adjust proto_tree_add_uint_format_value calls to use unit string Summary of changes: debian/libwireshark0.symbols | 11 +++++ epan/dissectors/file-jpeg.c | 12 ++--- epan/dissectors/packet-ansi_801.c | 20 ++++---- epan/dissectors/packet-aodv.c | 5 +- epan/dissectors/packet-bat.c | 8 ++-- epan/dissectors/packet-batadv.c | 8 ++-- epan/dissectors/packet-bfd.c | 5 +- epan/dissectors/packet-bootp.c | 9 ++-- epan/dissectors/packet-cattp.c | 7 +-- epan/dissectors/packet-cdp.c | 27 +++++------ epan/dissectors/packet-cip.c | 4 +- epan/dissectors/packet-cipmotion.c | 33 +++++-------- epan/dissectors/packet-dccp.c | 4 +- epan/dissectors/packet-dhcp-failover.c | 8 ++-- epan/dissectors/packet-dhcpv6.c | 5 +- epan/dissectors/packet-dnp.c | 5 +- epan/dissectors/packet-dsi.c | 13 ++--- epan/dissectors/packet-ecmp.c | 11 ++--- epan/dissectors/packet-ehdlc.c | 12 ++--- epan/dissectors/packet-esis.c | 36 ++++++-------- epan/dissectors/packet-fcswils.c | 19 +++----- epan/dissectors/packet-forces.c | 30 ++++++------ epan/dissectors/packet-geneve.c | 15 ++---- epan/dissectors/packet-gsm_a_dtap.c | 6 +-- epan/dissectors/packet-gsmtap.c | 7 ++- epan/dissectors/packet-gtpv2.c | 21 ++++---- epan/dissectors/packet-http.c | 10 ++-- epan/dissectors/packet-idp.c | 7 ++- epan/dissectors/packet-ieee80211-netmon.c | 7 ++- epan/dissectors/packet-ieee80211-radio.c | 30 ++++-------- epan/dissectors/packet-ieee80211-radiotap.c | 20 +++----- epan/dissectors/packet-ieee80211.c | 10 ++-- epan/dissectors/packet-igrp.c | 4 +- epan/dissectors/packet-ip.c | 5 +- epan/dissectors/packet-ipx.c | 5 +- epan/dissectors/packet-ipxwan.c | 40 +++++----------- epan/dissectors/packet-isakmp.c | 8 ++-- epan/dissectors/packet-isup.c | 13 ++--- epan/dissectors/packet-iwarp-ddp-rdmap.c | 10 ++-- epan/dissectors/packet-iwarp-mpa.c | 26 ++++------ epan/dissectors/packet-kerberos4.c | 3 +- epan/dissectors/packet-lat.c | 6 +-- epan/dissectors/packet-lmp.c | 13 ++--- epan/dissectors/packet-nbt.c | 22 ++++----- epan/dissectors/packet-nfs.c | 5 +- epan/dissectors/packet-nlsp.c | 37 ++++++-------- epan/dissectors/packet-opensafety.c | 37 +++++--------- epan/dissectors/packet-ospf.c | 5 +- epan/dissectors/packet-ppp.c | 6 +-- epan/dissectors/packet-ptp.c | 15 ++---- epan/dissectors/packet-q2931.c | 20 ++++---- epan/dissectors/packet-q931.c | 30 +++++------- epan/dissectors/packet-q933.c | 22 ++++----- epan/dissectors/packet-rsvp.c | 69 +++++++++------------------ epan/dissectors/packet-rtps.c | 22 ++++----- epan/dissectors/packet-scsi-ssc.c | 16 +++---- epan/dissectors/packet-scsi.c | 4 +- epan/dissectors/packet-sflow.c | 24 ++++------ epan/dissectors/packet-slimp3.c | 6 +-- epan/dissectors/packet-spice.c | 21 ++++---- epan/dissectors/packet-stt.c | 11 ++--- epan/dissectors/packet-tdmop.c | 2 +- epan/dissectors/packet-tds.c | 44 +++++++---------- epan/dissectors/packet-trmac.c | 10 ++-- epan/dissectors/packet-ua3g.c | 2 +- epan/dissectors/packet-udp.c | 24 ++++------ epan/unit_strings.c | 12 +++++ epan/unit_strings.h | 11 +++++ plugins/gryphon/packet-gryphon.c | 2 +- plugins/profinet/packet-pn-rtc-one.c | 30 +++++------- 70 files changed, 439 insertions(+), 628 deletions(-)
- Prev by Date: [Wireshark-commits] master a869ec6: Adjust proto_tree_add_[float|double]_format_value calls to use unit string
- Next by Date: [Wireshark-commits] wireshark-win32-libs rev 516: /tags/
- Previous by thread: [Wireshark-commits] master a869ec6: Adjust proto_tree_add_[float|double]_format_value calls to use unit string
- Next by thread: [Wireshark-commits] wireshark-win32-libs rev 516: /tags/
- Index(es):