Wireshark · Wireshark-commits: [Wireshark-commits] master f530b58: bthci_acl: Set src/dst addresses before reassembly.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f530b58bb5579e2727f76efa4d72d5025ea6bad1
Submitter: Stig Bjørlykke (stig@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

f530b58 by Stig Bjørlykke (stig@xxxxxxxxxxxxx):

    bthci_acl: Set src/dst addresses before reassembly.
    
    Set all addresses before we do reassembly because sub-dissectors may set
    their own addresses, and we don't want to override them again.
    
    This fixes "Follow TCP Stream" and shows the correct IP addresses in the
    Source and Destination columns when transporting IP packets.
    
    Allocate the addresses in pinfo pool to avoid possible stack buffer overflow.
    
    Bug: 13230
    Change-Id: I3b81ccb02b38331add4773d9bb3d5e0f6dcf025e
    Reviewed-on: https://code.wireshark.org/review/19201
    Petri-Dish: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    

Actions performed:

    from  9d85c4f   ssh: add dissection for Elliptic Curve Diffie-Hellman KEX
    adds  f530b58   bthci_acl: Set src/dst addresses before reassembly.


Summary of changes:
 epan/dissectors/packet-bthci_acl.c |   15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)