Wireshark-commits: [Wireshark-commits] master 6bc6512: ssh: correct inaccurate field names/abbrevs/
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6bc65121287e585d06755b3406c571ad9ba4d766
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
6bc6512 by Роман Донченко (dpb@xxxxxxxxxxxxxx):
ssh: correct inaccurate field names/abbrevs/id variable names
* kex_first_packet_follows -> first_kex_packet_follows
That's the name the spec (RFC 4253) uses.
* DH H signature -> H signature, DH host key -> host key
Neither the host key nor the H signature have much to do
with Diffie-Hellman. They're used in the same way in
every key exchange method that I know of, so their names
should be more generic.
* mpint_[ef] -> dh_[ef], mpint_[pg] -> dh_gex_[pg]
This is to make all key exchange method-specific fields follow
a consistent pattern with all names/abbrevs being prepended
by the method name.
Change-Id: Ic887fb92d8cbb6042e9b8e553cb5804db0ba4db8
Reviewed-on: https://code.wireshark.org/review/19199
Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
Actions performed:
from a494d1d smb/tftp: fix no previous prototype for ‘tftp/smb_eo_cleanup’ [-Wmissing-prototypes]
adds 6bc6512 ssh: correct inaccurate field names/abbrevs/id variable names
Summary of changes:
epan/dissectors/packet-ssh.c | 60 +++++++++++++++++++++---------------------
1 file changed, 30 insertions(+), 30 deletions(-)