Wireshark-commits: [Wireshark-commits] master f27f048: Cleanup dissection of endpoint addresses.
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 11 Dec 2016 04:19:35 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f27f048ee12b140b010f431dcfb9e588e130fcc8
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

f27f048 by Guy Harris (guy@xxxxxxxxxxxx):

    Cleanup dissection of endpoint addresses.
    
    All the pseudo-headers encode the endpoint as per a bEndpointAddress in
    sections 9.6.6 "Endpoint" of the USB 2.0 spec and the USB 3.1 spec, with
    a 4-bit endpoint number at the bottom and a 1-bit direction at the top
    with 0 = OUT and 1 = IN.
    
    Show the FreeBSD endpoint address the same way the other endpoint
    addresses are shown; the FreeBSD one is shown as a 4-byte little-endian
    value, but only the low-order (first) byte is used, so just show that
    byte.
    
    Call that field the "endpoint address", with the lower 4 bits being the
    "endpoint number" and the uppermost bit the "endpoint direction".
    
    Change-Id: Ic7358c7fb6b6df2502315b590eb5178cecb321d9
    Reviewed-on: https://code.wireshark.org/review/19200
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  54abb36   ssh: remove uninformative blurbs
    adds  f27f048   Cleanup dissection of endpoint addresses.


Summary of changes:
 epan/dissectors/packet-usb.c |   34 +++++++++++++++++-----------------
 1 file changed, 17 insertions(+), 17 deletions(-)