Wireshark-commits: [Wireshark-commits] master-2.2 abddc44: Add a comment explaining how a compiler
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 8 Dec 2016 20:41:37 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=abddc44ccaf1677b3763dc068b0c2acbe06a5655
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.2
Repository: wireshark

Commits:

abddc44 by Guy Harris (guy@xxxxxxxxxxxx):

    Add a comment explaining how a compiler bug where it's overly optimizing
    a combination of tests could cause the valgrind errors we were seeing,
    so we're zeroing the entire structure, padding included, to avoid that.
    
    Change-Id: I6713c870b0432a03b81dda3c3a50566853a9021c
    Reviewed-on: https://code.wireshark.org/review/19152
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  c6e6f79   cops: try to avoid uninitialized warning error
    adds  abddc44   Add a comment explaining how a compiler bug where it's overly optimizing a combination of tests could cause the valgrind errors we were seeing, so we're zeroing the entire structure, padding included, to avoid that.


Summary of changes:
 epan/dissectors/packet-cops.c |   22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)