Wireshark-commits: [Wireshark-commits] master 3496051: sdp: decode pt for more RTP transport protoc
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 8 Dec 2016 13:04:58 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3496051d07683a5ddee435c7dc521a157b142fa3
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

3496051 by Peter Wu (peter@xxxxxxxxxxxxx):

    sdp: decode pt for more RTP transport protocols
    
    Do not just decode the payload type for RTP/AVP, but also all RTP
    transport types.
    
    Add RTP/AVPF (same as normal RTP/AVP, but with additional RTCP formats).
    Similarly, add RTP/SAVPF and the two DTLS variants. Add references to
    the relevant specifications and order per IANA registry.
    
    Tested with dtls-srtp-ws-sip.pcapng, now the payload types under the
    "m=" tree have names and frames that were previously reported as RTP
    show up as SRTP. Frame 442 now shows "Encrypted RTCP Payload" warning
    instead of decoding it as garbage.
    
    Change-Id: I06893f385ec270391f8891e72a364d08d2354a0a
    Ping-Bug: 13193
    Reviewed-on: https://code.wireshark.org/review/19139
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  43706be   Qt: Fix currentOutputDeviceName() without QtMultimedia
    adds  3496051   sdp: decode pt for more RTP transport protocols


Summary of changes:
 epan/dissectors/packet-sdp.c |   55 ++++++++++++++++++++++++------------------
 1 file changed, 32 insertions(+), 23 deletions(-)