Wireshark-commits: [Wireshark-commits] master-2.2 35c5dab: DOF: fix UAT update callbacks
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 6 Dec 2016 16:06:49 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=35c5dab211b08540538771b62854afd890a3b84c
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master-2.2
Repository: wireshark

Commits:

35c5dab by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    DOF: fix UAT update callbacks
    
    - update callback must return a boolean to indicate success / failure
    - error message must be allcoated in glib memory as GUI will g_free it
    
    Bug: 13209
    Change-Id: Ibb9690034d66dae85e775d0010aadeb192c76b4a
    Reviewed-on: https://code.wireshark.org/review/19111
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    (cherry picked from commit 7c3ecc6956e456867ac7d216600ea3697b548eff)
    Reviewed-on: https://code.wireshark.org/review/19114
    

Actions performed:

    from  f3abfb2   packet-rpcrdma: Clean up Reply chunk dissection
    adds  35c5dab   DOF: fix UAT update callbacks


Summary of changes:
 epan/dissectors/packet-dof.c |  141 +++++++++++++++++++++---------------------
 1 file changed, 72 insertions(+), 69 deletions(-)