Wireshark-commits: [Wireshark-commits] master-2.2 3eecb9e: packet-rpcrdma: Fix Read list dissection
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 6 Dec 2016 13:05:35 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3eecb9e291a4297405c5682b6f0337c0509a6635
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master-2.2
Repository: wireshark

Commits:

3eecb9e by Chuck Lever (chuck.lever@xxxxxxxxxx):

    packet-rpcrdma: Fix Read list dissection
    
    The current mechanism of dissecting RPC-over-RDMA chunk lists is not
    working. It treats the Read list as a counted array (it's a list).
    
    Part of this confusion arises because RFC 5666 uses the term "chunk"
    to mean "chunk", "read segment", and "rdma segment". Re-organize
    the dissector logic to make this distinction properly.
    
    Bug: 13197
    Change-Id: Iad517804dbcf8b30de795af03af7a71a6f231231
    Signed-off-by: Chuck Lever <chuck.lever@xxxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/19099
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    (cherry picked from commit 149e42f7d5e4bbb988da7e9f7fc70efe87cbca2e)
    Reviewed-on: https://code.wireshark.org/review/19105
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  43b76c5   packet-rpcrdma: Remove if (tree) preventing dissectors being called.
    adds  3eecb9e   packet-rpcrdma: Fix Read list dissection


Summary of changes:
 epan/dissectors/packet-rpcrdma.c |   78 +++++++++++++++++++++++++++++++++++++-
 1 file changed, 77 insertions(+), 1 deletion(-)