Wireshark-commits: [Wireshark-commits] master 2994e63: SDP: add basic ICE candidate attribute disse
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 6 Dec 2016 00:14:27 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2994e63abbfbd3b57ade6d04a8737199537cddd5
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

2994e63 by Peter Wu (peter@xxxxxxxxxxxxx):

    SDP: add basic ICE candidate attribute dissection (RFC 5245)
    
    Dissect the first, fixed part of a=candidate. The candidate type is also
    unabbreviated for easier understanding. Tested with
    dtls-srtp-ws-sip.pcapng from the linked bug.
    
    Change-Id: I9950c8f066becea86f1fe8e9ffab2dc07ae0f425
    Ping-Bug: 13193
    Reviewed-on: https://code.wireshark.org/review/18997
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  8773ea0   CIP: Minor enhancements
    adds  2994e63   SDP: add basic ICE candidate attribute dissection (RFC 5245)


Summary of changes:
 epan/dissectors/packet-sdp.c |  153 +++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 151 insertions(+), 2 deletions(-)