Wireshark-commits: [Wireshark-commits] master-2.0 94a9d4b: Qt: clear Export Objects list on retappi
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 4 Dec 2016 11:44:00 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=94a9d4b4647c178551c61cafa7051986ad61ee5b
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

94a9d4b by Peter Wu (peter@xxxxxxxxxxxxx):

    Qt: clear Export Objects list on retapping
    
    The tap reset callback should not just invoke the reset callback of the
    dissector, but also clear the previous list of objects in the dialog.
    Otherwise duplicate entries will be created every time retapping occurs
    (e.g. on changing the display filter).
    
    Bug: 12230
    Change-Id: I75f25db0652dcc9c0ac59ab0e536c06874aedb9c
    Reviewed-on: https://code.wireshark.org/review/19055
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    (cherry picked from commit 5721a87330f8afe3fed12d4af250d7a3d219cbe2)
    [ Peter: resolved conflict in context ]
    Reviewed-on: https://code.wireshark.org/review/19065
    

Actions performed:

    from  eee5f97   packet-rpcrdma: Fix protocol frame pre-detection
    adds  94a9d4b   Qt: clear Export Objects list on retapping


Summary of changes:
 ui/qt/export_object_dialog.cpp |    1 +
 1 file changed, 1 insertion(+)